Add ipydatagrid/other-libraries notebooks, move old notebooks to widg… #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et_libraries folder Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
mwcraig
reviewed
Jun 27, 2021
| "\n", | ||
| "## https://github.com/bloomberg/ipydatagrid\n", | ||
| "\n", | ||
| "### Full canvas rendering\n", |
Contributor
There was a problem hiding this comment.
Is this a hold over from ipycanvas?
Member
Author
There was a problem hiding this comment.
Ha - not really, was only trying to emphasize we're using canvas rendering to display the grid. Should I reword this? Did you find it confusing?
Contributor
There was a problem hiding this comment.
A bit -- it seemed disconnected from what came after it.
Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
Contributor
|
@ibdafna -- is this ready to merge? |
mwcraig
force-pushed
the
more_widgets_2021
branch
from
ccee49c to
ad8dbd2
Compare
Member
Author
|
I'll just fix the remaining suggestions and then we can merge |
Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
…et_libraries folder Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
mwcraig
force-pushed
the
more_widgets_2021
branch
from
ad8dbd2 to
5c7a942
Compare
Member
Author
|
Somewhere during the rebase, I seem to have lost the updates made to the ipydatagrid notebook. Just trying to sort this now and will merge. |
ibdafna
force-pushed
the
more_widgets_2021
branch
from
9150743 to
ebe064c
Compare
Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…et_libraries folder
ipydatagridis complete. Still need to add content to the "other widget libraries" notebook.Signed-off-by: Itay Dafna i.b.dafna@gmail.com