Skip to content

Fix for frontend turning column names as integers into strings #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinRenou merged 1 commit into from
May 14, 2024
Merged

Fix for frontend turning column names as integers into strings #517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ipydatagrid/datagrid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,15 +433,17 @@ def __init__(self, dataframe, index_name=None, **kwargs):
def __handle_custom_msg(self, _, content, buffers): # noqa: U101,U100
if content["event_type"] == "cell-changed":
row = content["row"]
column = content["column"]
column = self._column_index_to_name(
self._data, content["column_index"]
)
value = content["value"]
# update data on kernel
self._data["data"].loc[row, column] = value
# notify python listeners
self._cell_change_handlers(
{
"row": row,
"column": content["column"],
"column": column,
"column_index": content["column_index"],
"value": value,
}
Expand Down
1 change: 0 additions & 1 deletion js/datagrid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,6 @@ export class DataGridModel extends DOMWidgetModel {
event_type: 'cell-changed',
region: msg.region,
row: msg.row,
column: msg.column,
column_index: msg.columnIndex,
value: msg.value,
},
Expand Down