Support RetroLab in Binder #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
force-pushed
the
retro_binder
branch
from
da5ecf7
to
500f067
Compare
davidbrochart
force-pushed
the
retro_binder
branch
from
500f067
to
ab81021
Compare
jtpio
reviewed
Sep 23, 2021
| @@ -337,7 +339,7 @@ def get_index(doc_name, retro_page, collaborative, base_url="/"): | |||
| <script id="jupyter-config-data" type="application/json"> | |||
| PAGE_CONFIG | |||
| </script> | |||
| <script src="/static/retro/bundle.js" main="index"></script> | |||
| <script src="BASE_URLstatic/retro/bundle.js" main="index"></script> | |||
There was a problem hiding this comment.
Maybe it could be useful to follow a similar syntax as in other template engines, for example with {{ BASE_URL }}?
There was a problem hiding this comment.
Yes, it's very fragile at the moment. But then without needing Jinja, right?
There was a problem hiding this comment.
But then without needing Jinja, right?
Yes still without Jinja. Just so it sticks out when reading the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71