Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fps_uvicorn plugin #67

Merged
merged 6 commits into from
Sep 22, 2021

Conversation

adriendelsalle
Copy link
Member

Description

jupyter-server/fps#32 moved uvicorn and corresponding CLI to a dedicated plugin.

Use fps_uvicorn plugin:

  • use config moved from fps to fps_uvicorn
  • update dependencies
  • use logger to print link in console

adriendelsalle and others added 2 commits September 22, 2021 17:48
use  config moved from fps to fps_uvicorn
update dependencies
use logger to print link in console
@davidbrochart
Copy link
Collaborator

ImportError: cannot import name 'get_configured_logger' from 'fps.logging' (/usr/share/miniconda/envs/jupyverse-dev/lib/python3.9/site-packages/fps/logging.py)
@adriendelsalle aren't we missing a FPS release?

@adriendelsalle
Copy link
Member Author

adriendelsalle commented Sep 22, 2021

I didn't released yet after merging jupyter-server/fps#32 , did you tested on master or is it only the CI output?
I would be happy if you can try a bit without cutting a release

@davidbrochart
Copy link
Collaborator

[E 2021-09-22 16:15:46 fps] Config model '<class 'fps_uvicorn.config.UvicornConfig'>' is not yet registered

@davidbrochart
Copy link
Collaborator

Looks like tests pass, I could wait for an FPS release and install fps[uvicorn] in this PR?

@adriendelsalle
Copy link
Member Author

@davidbrochart I just fixed the issue (jupyter-server/fps#35)

Works locally, I already released fps-uvicorn 0.0.2 and fps 0.0.8

@adriendelsalle
Copy link
Member Author

Looks like tests pass, I could wait for an FPS release and install fps[uvicorn] in this PR?

yes it should work now

@davidbrochart
Copy link
Collaborator

Maybe still worth keeping FPS master in the CI, as we are co-developing FPS and jupyverse?

@davidbrochart davidbrochart merged commit 8c5bd41 into jupyter-server:main Sep 22, 2021
@adriendelsalle
Copy link
Member Author

It would be a good way to catch breaking changes. Up to you!

@adriendelsalle adriendelsalle deleted the uvicorn-config branch September 22, 2021 16:42
@davidbrochart
Copy link
Collaborator

Thanks @adriendelsalle !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants