-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fps_uvicorn
plugin
#67
Use fps_uvicorn
plugin
#67
Conversation
use config moved from fps to fps_uvicorn update dependencies use logger to print link in console
|
I didn't released yet after merging jupyter-server/fps#32 , did you tested on master or is it only the CI output? |
|
Looks like tests pass, I could wait for an FPS release and install |
@davidbrochart I just fixed the issue (jupyter-server/fps#35) Works locally, I already released |
yes it should work now |
Maybe still worth keeping FPS master in the CI, as we are co-developing FPS and jupyverse? |
It would be a good way to catch breaking changes. Up to you! |
Thanks @adriendelsalle ! |
Description
jupyter-server/fps#32 moved
uvicorn
and corresponding CLI to a dedicated plugin.Use
fps_uvicorn
plugin: