Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consoles and terminals handlers for RetroLab #54

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 17, 2021

Consoles and terminals are also supported in RetroLab.

@welcome
Copy link

welcome bot commented Sep 17, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jtpio jtpio marked this pull request as ready for review September 17, 2021 14:01
@jtpio jtpio mentioned this pull request Sep 17, 2021
@davidbrochart
Copy link
Collaborator

When I click on New Console, I get:

[I 2021-09-20 12:05:48 uvicorn.access] 127.0.0.1:52432 - "GET /retro/consoles//console-1-18b61535-c104-4cf2-a3e9-3c6f23fe4fae HTTP/1.1" 404 Not Found

I guess it's because of the double slash.
Also, is it normal that going to File -> New only shows Console and Notebook (no File or Terminal)?

@jtpio
Copy link
Member Author

jtpio commented Sep 20, 2021

I guess it's because of the double slash.

Probably yes. Creating a new console from a notebook works fine (for example when the path is just Untitled.ipynb).

Also, is it normal that going to File -> New only shows Console and Notebook (no File or Terminal)?

I think it's because not all the plugins are loaded on the tree page. Mind opening an issue in the retrolab repo? Thanks!

@davidbrochart davidbrochart merged commit 112fa00 into jupyter-server:main Sep 20, 2021
@welcome
Copy link

welcome bot commented Sep 20, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@davidbrochart
Copy link
Collaborator

Thanks!

@jtpio jtpio deleted the retro-handlers branch September 20, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants