Fix incomplete kernel search path

[Wh1isper]

No description provided.

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[Wh1isper]

cc @davidbrochart

[Wh1isper]

I missed the change to the kernel driver, will check the jupyter kernelspec search path

[davidbrochart]

Thanks for the PR @Wh1isper, any idea why tests fail?

[Wh1isper]

Thanks for the PR @Wh1isper, any idea why tests fail?

It seems like starlette switch requests to httpx and not support get with body

https://github.com/encode/starlette/blob/master/starlette/testclient.py#L470

[Wh1isper]

refer to this
https://www.python-httpx.org/compatibility/#request-body-on-http-methods
ci have beed fixed

cc @davidbrochart

[davidbrochart]

It seems like starlette switch requests to httpx and not support get with body

Should we require starlette >=0.21.0?

[Wh1isper]

It seems like starlette switch requests to httpx and not support get with body

Should we require starlette >=0.21.0?

fastapi ==0.87.0 will get starlette==0.21.0, require fastapi >=0.87.0 should be ok?

I'm new to fastapi, it looks like fastapi will follow up with starlette for updates

[davidbrochart]

fastapi ==0.87.0 will get starlette==0.21.0, require fastapi >=0.87.0 should be ok?

Yes, let's require fastapi >=0.87.0 then 👍

[davidbrochart]

Awesome, thanks a lot @Wh1isper !

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

[davidbrochart]

Just as a side note, you should create a branch on your fork before making a PR, instead of committing on main.

[Wh1isper]

Just as a side note, you should create a branch on your fork before making a PR, instead of committing on main.

Thanks for the reminder, I realized that each PR will be squeezed into a new commit rather than just merged

[davidbrochart]

In this particular case, I squashed your PR.