Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a base auth plugin to depend on instead of jupyverse #232

Merged
merged 7 commits into from
Sep 21, 2022
Merged

Create a base auth plugin to depend on instead of jupyverse #232

merged 7 commits into from
Sep 21, 2022

Conversation

hbcarlos
Copy link
Contributor

@hbcarlos hbcarlos marked this pull request as draft September 20, 2022 17:01
davidbrochart
davidbrochart requested changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Carlos, that looks good.

plugins/auth_base/fps_auth_base/__init__.py Outdated Show resolved Hide resolved
fps_cli_args.toml Outdated Show resolved Hide resolved
plugins/auth_base/pyproject.toml Outdated Show resolved Hide resolved
@hbcarlos
Copy link
Contributor Author

Thanks, David! I added a commit with the changes.

@hbcarlos hbcarlos marked this pull request as ready for review September 20, 2022 21:20
davidbrochart
davidbrochart reviewed Sep 21, 2022
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@davidbrochart davidbrochart merged commit 2c1499e into jupyter-server:main Sep 21, 2022
@hbcarlos hbcarlos deleted the base_auth branch September 21, 2022 07:22
@hbcarlos hbcarlos mentioned this pull request Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbrochart davidbrochart davidbrochart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbcarlos @davidbrochart