Merge pull request #126 from davidbrochart/fix_get_content

Return 404 when content not found

plugins/contents/fps_contents/models.py

@@ -19,7 +19,7 @@ class Content(BaseModel):
     name: str
     path: str
     last_modified: Optional[str]
-    created: str
+    created: Optional[str]
     content: Optional[Union[str, List[Dict]]]
     format: Optional[str]
     mimetype: Optional[str]

plugins/contents/fps_contents/routes.py

@@ -6,7 +6,7 @@
 from typing import Dict, List, Optional, Union, cast
 
 from fps.hooks import register_router  # type: ignore
-from fastapi import APIRouter, Depends
+from fastapi import APIRouter, Depends, HTTPException
 from starlette.requests import Request  # type: ignore
 
 from fps_auth.backends import current_user  # type: ignore
@@ -165,15 +165,14 @@ def get_path_content(path: Path, get_content: bool):
                 with open(path) as f:
                     content = f.read()
             except Exception:
-                # FIXME: return error code?
-                pass
+                raise HTTPException(status_code=404, detail="Item not found")
     format: Optional[str] = None
     if path.is_dir():
         size = None
         type = "directory"
         format = "json"
         mimetype = None
-    else:
+    elif path.is_file():
         size = get_file_size(path)
         if path.suffix == ".ipynb":
             type = "notebook"
@@ -187,6 +186,8 @@ def get_path_content(path: Path, get_content: bool):
             type = "file"
             format = None
             mimetype = "text/plain"
+    else:
+        raise HTTPException(status_code=404, detail="Item not found")
 
     return {
         "name": path.name,