Skip to content

Fix syntax highlighting regression (default metadata structure not being set) #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
Merged

Fix syntax highlighting regression (default metadata structure not being set) #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a0acdf
Add a test for default metadata being set
krassowski Nov 18, 2025
89542d9
Fix the initial comparison to ensure Map gets set
krassowski Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jupyter_ydoc/ynotebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def set(self, value: Dict) -> None:
self._ymeta["nbformat_minor"] = nbformat_minor

old_y_metadata = self._ymeta.get("metadata")
old_metadata = old_y_metadata.to_py() if old_y_metadata else {}
old_metadata = old_y_metadata.to_py() if old_y_metadata else None
metadata = nb.get("metadata", {})

if metadata != old_metadata:
Expand Down
9 changes: 9 additions & 0 deletions tests/test_ynotebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ def record_changes(topic, event):
assert changes == []


def test_set_populates_metadata():
nb = YNotebook()
nb.set({"cells": []})
assert nb.get()["metadata"] == {
"kernelspec": {"display_name": "", "name": ""},
"language_info": {"name": ""},
}


def test_set_preserves_cells_with_insert_and_remove():
nb = YNotebook()
nb.set(
Expand Down
Loading