Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch away from deprecated zmqhandlers module in Jupyter Server 2.0 #62

Merged
merged 3 commits into from
Nov 21, 2022

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Nov 20, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 82.57% // Head: 82.57% // No change to project coverage 👍

Coverage data is based on head (11ef6ab) compared to base (36dcd76).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   82.57%   82.57%           
=======================================
  Files           7        7           
  Lines         241      241           
  Branches       38       38           
=======================================
  Hits          199      199           
  Misses         33       33           
  Partials        9        9           
Impacted Files Coverage Δ
jupyter_server_terminals/handlers.py 74.35% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 enabled auto-merge (squash) November 21, 2022 18:01
@blink1073 blink1073 merged commit 37da434 into jupyter-server:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants