Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in readme #3

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Conversation

JasonWeill
Copy link
Contributor

Convert absolute link to relative, complete a malformed link

@welcome
Copy link

welcome bot commented Jan 6, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@JasonWeill
Copy link
Contributor Author

Can a dev with permissions to do so please add label "documentation" to this PR so that it passes pre-commit checks? Thanks!

@blink1073 blink1073 added the documentation Improvements or additions to documentation label Jan 7, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The other link failure is unrelated

@blink1073 blink1073 merged commit 16d481f into jupyter-server:main Jan 7, 2022
@welcome
Copy link

welcome bot commented Jan 7, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants