Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add authorization #11

Merged
merged 2 commits into from
Apr 3, 2022
Merged

Add authorization #11

merged 2 commits into from
Apr 3, 2022

Conversation

blink1073
Copy link
Contributor

We should probably put some of the auth utility functions/features in jupyter_server/pytest_plugin.py.

@blink1073 blink1073 added the enhancement New feature or request label Apr 3, 2022
willingc
willingc approved these changes Apr 3, 2022
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit for clarity. Good to go as is too.

@blink1073 @willingc
Update jupyter_server_terminals/handlers.py
e488282 
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
@blink1073 blink1073 mentioned this pull request Apr 3, 2022
Closed
@blink1073 blink1073 merged commit 77a4f85 into jupyter-server:main Apr 3, 2022
@blink1073 blink1073 deleted the add-auth branch April 3, 2022 00:24
@blink1073 blink1073 mentioned this pull request Apr 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @willingc