Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document the logging_config trait #844

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

oliver-sanders
Copy link
Contributor

@oliver-sanders oliver-sanders commented May 13, 2022

Addresses #684

(will fail CI until Traitlets 5.2.1 is released)

  • Bump minimum traitlets version from 5.1 to 5.2.1 (not yet released).
    • This gives us access to the logging_config trait.
    • Don't know if you want to bump the traitlets version or just add a note that this is a new feature of Traitlets 5.2.0.
    • Note Traitlets 5.2.0 has a couple of bugs so best to wait for 5.2.1 before advertising this.
  • Document how to use logging_config with Jupyter Server / extension applications.

@blink1073
Copy link
Contributor

I think depending on traitlets >= 5.2.1 sounds good, since this is targeting 2.0

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

Base: 75.14% // Head: 75.14% // No change to project coverage 👍

Coverage data is based on head (884a47a) compared to base (cf902ea).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #844   +/-   ##
=======================================
  Coverage   75.14%   75.14%           
=======================================
  Files          63       63           
  Lines        8225     8225           
  Branches     1635     1635           
=======================================
  Hits         6181     6181           
  Misses       1624     1624           
  Partials      420      420           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oliver-sanders oliver-sanders marked this pull request as ready for review May 16, 2022 13:51
@oliver-sanders
Copy link
Contributor Author

(deconflicted)

@blink1073
Copy link
Contributor

I pushed a change to increase the minimum to 5.3, since I had some difficulties with the 5.2.x traitlets releases 😅

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@blink1073 blink1073 merged commit 830c87f into jupyter-server:main Nov 15, 2022
@oliver-sanders oliver-sanders deleted the logging_config branch November 15, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants