Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure terminal cwd exists #755

Merged
merged 6 commits into from
Mar 25, 2022
Merged

Ensure terminal cwd exists #755

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
193d7e0
Ensure terminal cwd exists
fcollonval Mar 24, 2022
8d01f76
Fix CI
fcollonval Mar 24, 2022
75bb5aa
Fix unit tests
fcollonval Mar 24, 2022
c562ee8
Add debug message and try to fix windows tests
fcollonval Mar 24, 2022
d340c80
Expand user folder
fcollonval Mar 24, 2022
b339cb1
Correct debug msg
fcollonval Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Correct debug msg
  • Loading branch information
@fcollonval
fcollonval authored Mar 24, 2022
commit b339cb10806ba52ca9ef4da53eb3071a1c4a3390
4 changes: 3 additions & 1 deletion jupyter_server/terminal/api_handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ def post(self):
cwd = None

if cwd is None:
server_root_dir = self.settings["server_root_dir"]
self.log.debug(
f"Failed to find requested terminal cwd: {data.get('cwd')}\n It was not found within the server root neither: {cwd.resolve()!s}."
f"Failed to find requested terminal cwd: {data.get('cwd')}\n"
f" It was not found within the server root neither: {server_root_dir}."
)
del data["cwd"]
else:
Expand Down