Skip to content

remove redundant pylint check #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,3 @@ repos:
rev: v7.32.0
hooks:
- id: eslint
- repo: https://github.com/pre-commit/mirrors-pylint
rev: v3.0.0a3
hooks:
- id: pylint
args: [--disable=all, --enable=unused-import]
2 changes: 1 addition & 1 deletion docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@
spelling_word_list_filename = "spelling_wordlist.txt"

# import before any doc is built, so _ is guaranteed to be injected
import jupyter_server.transutils # pylint: disable=unused-import
import jupyter_server.transutils # noqa: F401


def setup(app):
Expand Down
2 changes: 1 addition & 1 deletion examples/simple/conftest.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
from jupyter_server.conftest import *
from jupyter_server.conftest import * # noqa
2 changes: 1 addition & 1 deletion jupyter_server/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

del os

from ._version import version_info, __version__
from ._version import version_info, __version__ # noqa


def _cleanup():
Expand Down
2 changes: 1 addition & 1 deletion jupyter_server/auth/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
from .security import passwd
from .security import passwd # noqa
1 change: 0 additions & 1 deletion jupyter_server/prometheus/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
# Jupyter Notebook also defines these metrics. Re-defining them results in a ValueError.
# Try to de-duplicate by using the ones in Notebook if available.
# See https://github.com/jupyter/jupyter_server/issues/209
# pylint: disable=unused-import
from notebook.prometheus.metrics import (
HTTP_REQUEST_DURATION_SECONDS,
TERMINAL_CURRENTLY_RUNNING_TOTAL,
Expand Down
1 change: 0 additions & 1 deletion jupyter_server/serverapp.py
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,6 @@ def shutdown_server(server_info, timeout=5, log=None):
Returns True if the server was stopped by any means, False if stopping it
failed (on Windows).
"""
from tornado.httpclient import HTTPClient, HTTPRequest

url = server_info["url"]
pid = server_info["pid"]
Expand Down
2 changes: 1 addition & 1 deletion jupyter_server/services/config/__init__.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
from .manager import ConfigManager
from .manager import ConfigManager # noqa
4 changes: 2 additions & 2 deletions jupyter_server/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
from urllib.parse import quote
from urllib.parse import SplitResult
from urllib.parse import unquote
from urllib.parse import urljoin # pylint: disable=unused-import
from urllib.parse import urljoin # noqa: F401
from urllib.parse import urlparse
from urllib.parse import urlsplit
from urllib.parse import urlunsplit
from urllib.request import pathname2url # pylint: disable=unused-import
from urllib.request import pathname2url # noqa: F401

from tornado.httpclient import AsyncHTTPClient
from tornado.httpclient import HTTPClient
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ console_scripts =
exclude = ['docs*', 'examples*']

[flake8]
ignore = E, C, W, F401, F403, F811, F841, E402, I100, I101, D400
ignore = E, C, W, F403, F811, F841, E402, I100, I101, D400
builtins = c, get_config
exclude =
.cache,
Expand Down