Skip to content

Shutdown kernels/terminals on api/shutdown #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blink1073 merged 4 commits into from
Sep 9, 2021
Merged

Shutdown kernels/terminals on api/shutdown #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4e823c
Shutdown kernels on api/shutdown
martinRenou Sep 6, 2021
ec99ae8
Shutdown terminals on api/shutdown
martinRenou Sep 6, 2021
4ae0615
Call cleanup on api/shutdown
martinRenou Sep 6, 2021
4c59367
Fix call to cleanup
martinRenou Sep 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions jupyter_server/base/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,10 @@ def jinja_template_vars(self):
"""User-supplied values to supply to jinja templates."""
return self.settings.get("jinja_template_vars", {})

@property
def serverapp(self):
return self.settings["serverapp"]

# ---------------------------------------------------------------
# URLs
# ---------------------------------------------------------------
Expand Down
5 changes: 4 additions & 1 deletion jupyter_server/services/shutdown.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,11 @@

class ShutdownHandler(JupyterHandler):
@web.authenticated
def post(self):
async def post(self):
self.log.info("Shutting down on /api/shutdown request.")

await self.serverapp._cleanup()

ioloop.IOLoop.current().stop()


Expand Down