Skip to content

Conversation

@manics
Copy link
Contributor

@manics manics commented Jul 23, 2021

I spotted a typo in the help output for allow_password_change

@welcome
Copy link

welcome bot commented Jul 23, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2021

Codecov Report

Merging #559 (b151479) into master (05913dd) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
- Coverage   76.99%   76.95%   -0.05%     
==========================================
  Files         109      109              
  Lines        9948     9948              
  Branches     1078     1078              
==========================================
- Hits         7659     7655       -4     
- Misses       1909     1912       +3     
- Partials      380      381       +1     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 66.10% <ø> (ø)
jupyter_server/services/kernels/handlers.py 61.37% <0.00%> (-1.59%) ⬇️
jupyter_server/tests/services/kernels/test_api.py 99.01% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05913dd...b151479. Read the comment docs.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kevin-bates kevin-bates merged commit 7d2f04f into jupyter-server:master Jul 23, 2021
@welcome
Copy link

welcome bot commented Jul 23, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@manics manics deleted the patch-1 branch July 23, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants