Await _connect and inline read_messages callback to _connect #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
==========================================
+ Coverage 67.07% 67.38% +0.31%
==========================================
Files 55 55
Lines 5352 5357 +5
Branches 696 695 -1
==========================================
+ Hits 3590 3610 +20
+ Misses 1555 1543 -12
+ Partials 207 204 -3
Continue to review full report at Codecov.
|
kevin-bates
approved these changes
Nov 21, 2020
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
Looks good Rick - thank you!
I've taken these changes for a spin in my EG configuration and they are essential to supporting EG from jupyter-server!
Member
|
@meeseeksdev backport to 1.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter_server
that referenced
this pull request
Dec 2, 2020
…es callback to _connect
kevin-bates
added a commit
that referenced
this pull request
Dec 3, 2020
…on-1.0.x Backport PR #350 on branch 1.0.x (Await _connect and inline read_messages callback to _connect)
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
…-fix Await _connect and inline read_messages callback to _connect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix an issue with the gateway handler introduced by the switch to native async function for the
_connectfunction in the gateway websocket handler (which originally used the @gen coroutine version fromtornado)._connectshould now be properly awaited through IOLoop'sspawn_callbackmechanism.@kevin-bates recommended a PR based on this discussion jupyter-server/enterprise_gateway#903.