Switch fixtures to use those in pytest-jupyter to avoid collisions #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2020
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
…plugins Switch fixtures to use those in pytest-jupyter to avoid collisions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
pytest-jupyteris released, this updates the custom fixtures to use theirjp_versions made available viapytest-jupyter. This will avoid collisions with similarly named fixtures introduced in other packages (provided of course, they too are not prefixed withjp_😄 ).Note that because other packages still depend on
jupyter_server/pytest_plugin.pyfor the non-prefixed features, both it as well as thepytest_jupyter_serverentrypoint remain in existence.Prior to removing
jupyter_server/pytest_plugin.pyand thepytest_jupyter_serverentrypoint, we may want to cut a release to provide dependents a "pin point" until they've prefixed the jupyter server fixtures.Resolves #322