Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Batch 6] Porting Notebook PRs #104

Merged
merged 11 commits into from
Sep 27, 2019
Merged

[Batch 6] Porting Notebook PRs #104

merged 11 commits into from
Sep 27, 2019

Commits on Sep 27, 2019

  1. Fix incorrect MIME type for JavaScript

    @satchel3037 @Zsailer
    satchel3037 authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    569183e View commit details
    Browse the repository at this point in the history

  2. Fix comment

    @satchel3037 @Zsailer
    satchel3037 authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    b6550eb View commit details
    Browse the repository at this point in the history

  3. explicitly ignore windows registry for mimetypes 

    since it has proven untrustworthy for many users
    @minrk @Zsailer
    minrk authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    d8c4573 View commit details
    Browse the repository at this point in the history

  4. Changed the default protocol 

    Applied suggestion from review

Fixed hasattr issue
    @xmnlab @Zsailer
    xmnlab authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    2094026 View commit details
    Browse the repository at this point in the history

  5. Improve code, add docstring

    @xmnlab @Zsailer
    xmnlab authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    ff3017f View commit details
    Browse the repository at this point in the history

  6. Fixed small issue and added more information about PROTOCOL_TLS

    @xmnlab @Zsailer
    xmnlab authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    b4bcb88 View commit details
    Browse the repository at this point in the history

  7. Added control channel to ZMQChannelsHandler

    @JohanMabille @Zsailer
    JohanMabille authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    d2adacb View commit details
    Browse the repository at this point in the history

  8. Bumped the required version of jupyter_client

    @JohanMabille @Zsailer
    JohanMabille authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    8b74f01 View commit details
    Browse the repository at this point in the history

  9. bfix: shutdown_server returns True when pid exists 

    `check_pid` returns `True` if the PID for a notebook server still exists. Therefore, the `if check_pid(pid):` statements on lines 424 and 437 evaluate to `True` even though the notebook server is still running.

This commit simply adds a `not` to each line: `if not check_pid(pid):` so that the conditional only evaluates to `True` if `check_pid` returns `False`, which happens when the notebook server has shutdown, as expected.
    @asreimer @Zsailer
    asreimer authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    d62f738 View commit details
    Browse the repository at this point in the history

  10. Added decorator 

    Added decorator `@gen.coroutine` to `FileHandler.get()`
    @TomTJarosz @Zsailer
    TomTJarosz authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    d1ec4bc View commit details
    Browse the repository at this point in the history

  11. Import gen

    @TomTJarosz @Zsailer
    TomTJarosz authored and Zsailer committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    21fc939 View commit details
    Browse the repository at this point in the history