Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Excel custom sheet #338

Merged
merged 3 commits into from
Mar 1, 2022
Merged

feat: Excel custom sheet #338

merged 3 commits into from
Mar 1, 2022

Conversation

Sebgh83
Copy link
Contributor

@Sebgh83 Sebgh83 commented Feb 15, 2022

No description provided.

@FlorentLvr FlorentLvr linked an issue Feb 15, 2022 that may be closed by this pull request
@FlorentLvr FlorentLvr added the good first issue Good for newcomers label Feb 15, 2022
@FlorentLvr FlorentLvr self-requested a review February 15, 2022 16:33
@Sebgh83
Copy link
Contributor Author

Sebgh83 commented Feb 22, 2022

Hi @FlorentLvr . I think the script is done. Can you review it please ?

@FlorentLvr
Copy link
Contributor

FlorentLvr commented Feb 24, 2022

Hi @Sebgh83 ! TY for your contribution. It's working well.
I reworked the structure:

  • I put all variables on top => then it's easier to setup and understand
  • I used variables instead of string.
    => For example, i set the sheet range as variable. Then it's easier to change.
  • I removed useless libraries

I also added a new notebook to get the active range dynamically. I am sure it could help on the future. :)
Could you please have a look and let me know if it's good for you ?

@Sebgh83
Copy link
Contributor Author

Sebgh83 commented Mar 1, 2022

Hi @FlorentLvr,

Thanks for the edits. I take note of the remarks to improve the next script.

Thank's again, I appreciate it

@FlorentLvr
Copy link
Contributor

TY @Sebgh83 and welcome to the community 🥇

Naas_contrib_step1

@FlorentLvr FlorentLvr merged commit 5f8044c into master Mar 1, 2022
@FlorentLvr FlorentLvr deleted the Excel_custom branch March 1, 2022 13:58
@jravenel
Copy link
Contributor

jravenel commented Mar 1, 2022

Hello @Sebgh83, welcome to the contributor team, do you have 15min so we can record a demo of your template for content creation? Looking forward to it!

@Sebgh83
Copy link
Contributor Author

Sebgh83 commented Mar 1, 2022

Hi @jravenel Jeremy. A little complicated right now for the video but you can find a 5 minute video tutorial on my last linkedin post that I made last week. clearly top for the script :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excel - Custom reformat dataframe to Excel sheet
4 participants