Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dynamic link on label click plotly chart python #1268

Conversation

oguzakif
Copy link
Contributor

Input:
✔️ App setup

Model:
✔️ Create plotly graph
✔️ Create a Dash app with Plotly graph
✔️ Setup callback

Output:
✔️ Display app

This PR closes #1249

@oguzakif
Copy link
Contributor Author

Hi, I have opened the pr again this branch as you requested. Thank you for your feedback!

@FlorentLvr FlorentLvr removed the request for review from jravenel October 18, 2022 14:43
@FlorentLvr
Copy link
Contributor

@oguzakif, TY for your contribution!
I tried to click on a label but nothing happen on Dash. The error below appears in the log.
Can you reproduce it?

image

@oguzakif
Copy link
Contributor Author

@oguzakif, TY for your contribution! I tried to click on a label but nothing happen on Dash. The error below appears in the log. Can you reproduce it?

image

Thank you! I fixed the given error. The problem was missed condition in callback function. Also fixed the problem of new tab not opening with client-side callback. (Btw these problems were in naas. I didnt encounter them in my local computer)

@oguzakif oguzakif requested a review from jravenel October 19, 2022 12:07
@FlorentLvr
Copy link
Contributor

FlorentLvr commented Oct 21, 2022

@oguzakif, TY for your contribution! I tried to click on a label but nothing happen on Dash. The error below appears in the log. Can you reproduce it?
image

Thank you! I fixed the given error. The problem was missed condition in callback function. Also fixed the problem of new tab not opening with client-side callback. (Btw these problems were in naas. I didnt encounter them in my local computer)

TY @oguzakif! It's working well now :) 🍾
@jravenel, it's going to be super useful for our product analytics!

@FlorentLvr FlorentLvr merged commit 471b4ba into master Oct 21, 2022
@FlorentLvr FlorentLvr deleted the 1249-dash-plotly-add-dynamic-link-on-label-click-on-plotly-chart-python branch October 21, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dash Plotly - Add dynamic link on label click on plotly chart python
2 participants