feat: add middleware and traefik deployments to hyperpod helm chart #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGuinegagne
previously approved these changes
Oct 27, 2025
| kind: ClusterRole | ||
| metadata: | ||
| name: authmiddleware-role | ||
| rules: [] # No Kubernetes API permissions needed |
There was a problem hiding this comment.
Watch out: you might need these permissions for cookie renewal
There was a problem hiding this comment.
will add in follow up. atm it seems it will be tripped by this.
| apiVersion: traefik.io/v1alpha1 | ||
| kind: Middleware | ||
| metadata: | ||
| name: authmiddleware-auth |
There was a problem hiding this comment.
consider renaming bearer-auth to avoid conflicts in the future if a cluster supports both oauth and bearer flows.
There was a problem hiding this comment.
ah sorry I did some replacing but missed this. let me update.
| service.beta.kubernetes.io/aws-load-balancer-type: "nlb" | ||
| service.beta.kubernetes.io/aws-load-balancer-nlb-target-type: "ip" | ||
| service.beta.kubernetes.io/aws-load-balancer-scheme: "internet-facing" | ||
| # Pass TLS traffic to Traefik as TCP to allow Traefik to handle TLS termination using Let's Encrypt |
There was a problem hiding this comment.
sanity-check: doesn't the TLS termination occurs in the NLB in this chart? does this comment need to be updated?
There was a problem hiding this comment.
this comment needs to be updated... i have not implemented TLS in this chart yet.
joshuatowner
force-pushed
the
hyp-add-middleware-deployment
branch
from
242b31e to
501987f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Authentication Middleware and Traefik Integration to AWS HyperPod Helm Chart
Adds comprehensive authentication and reverse proxy infrastructure to enable secure access to Jupyter workspaces with JWT-based authentication and Traefik routing.
Changes
• Authentication Middleware: Deployment, RBAC, and service for JWT validation, cookie management, and CSRF protection
• Traefik Reverse Proxy: Deployment with AWS LoadBalancer integration, TLS termination, RBAC permissions, and health check services
• Auth Middlewares: Traefik middleware configurations for authentication flow, header management, and path routing
This is mainly pulled from the other helm chart, but with changes to support bearer-auth and removing oauth support.