Template overriding fields with its default values

[earaghbidikashani]

we will need to drive consensus on: should we merge things like labels or completely override?

this is similar to environment variables. can you make an issue to track?

Originally posted by @joshuatowner in #86 (comment)

[andrii-i]

Sharing my thoughts on env vars overrides. I think labels should follow the same design.

Not allowing env var overwrite makes both user and admin experience less flexible while always allowing overwrite decreases the admin enforcement capabilities and potentially introduces security risks. Ability to optionally mark an env var as immutable in the WorkspaceTemplate provides a hybrid approach I'd recommend:

Example :

kind: WorkspaceTemplate
spec:
  environmentVariables:
    - name: JUPYTER_TOKEN_REQUIRED
      value: "yes"
      immutable: true # can't be overriden by Workspace           
    - name: JUPYTER_ENABLE_LAB
      value: "yes"
      immutable: true              
    - name: DEFAULT_THEME
      value: "light" # mutable, as immutable is false by default

Note that accessStrategy.Spec.MergeEnv also support setting env vars, and that should take precedence over anything else (template or ws specs).