Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Code block lineno-start turns on line numbers #46

Merged
merged 3 commits into from
Sep 16, 2022
Merged

🐛 Code block lineno-start turns on line numbers #46

merged 3 commits into from
Sep 16, 2022

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Sep 6, 2022

@rowanc1 rowanc1 requested a review from fwkoch September 6, 2022 15:24
rowanc1 added a commit to jupyter-book/mystmd that referenced this pull request Sep 6, 2022
@rowanc1
🐛 Code block lineno-start turns on line numbers
6c613db 
See also jupyter-book/myst-spec#46

See https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-option-code-block-lineno-start
fwkoch
fwkoch approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@fwkoch fwkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change the title of the test too:

- title: Code-block directive shows line numbers without explicit linenos flag or something

@rowanc1 rowanc1 merged commit 14d1e42 into main Sep 16, 2022
@rowanc1 rowanc1 deleted the code-block branch September 16, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwkoch fwkoch fwkoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rowanc1 @fwkoch