Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ REFACTOR: mystDirective/mystRole kind -> name #35

Merged
merged 2 commits into from
Apr 11, 2022
Merged

♻️ REFACTOR: mystDirective/mystRole kind -> name #35

merged 2 commits into from
Apr 11, 2022

Conversation

chrisjsewell
Copy link
Contributor

closes #31

@chrisjsewell chrisjsewell requested review from fwkoch and rowanc1 April 7, 2022 21:05
@rowanc1
Copy link
Member

rowanc1 commented Apr 7, 2022

Looks good to me! @fwkoch do you want to take a closer look and commit this if all is solid?!

@rowanc1 rowanc1 mentioned this pull request Apr 11, 2022
Open
7 tasks
@fwkoch fwkoch merged commit bb3abe8 into main Apr 11, 2022
@fwkoch fwkoch deleted the kind-to-name branch April 11, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwkoch fwkoch fwkoch approved these changes

@rowanc1 rowanc1 Awaiting requested review from rowanc1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mystRole/mystDirective: use name instead of kind
3 participants
@chrisjsewell @rowanc1 @fwkoch