Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic WrapperBase.root property #135

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Add basic WrapperBase.root property #135

merged 4 commits into from
Sep 13, 2023

Conversation

nrbgt
Copy link
Contributor

@nrbgt nrbgt commented Sep 13, 2023

Checklist

  • the PR target is correct
    • main for postmortem, docs-only fixes, and post-release hot-fixes
    • dev for everything else
  • ran doit lint locally

References

Code changes

  • relock yarn, mamba
  • add .root to WrapperBase
  • trivial cycle detection
  • tests
  • changelog

User-facing changes

  • users will be able to request the final value of a wrapper (by way of any intermediate .wrapped)
  • wrappers cannot have themselves as their own .wrapped (and therefore .root)

Backwards-incompatible changes

  • probably none

@nrbgt nrbgt changed the title Add basic WrapperBase.root Add basic WrapperBase.root property Sep 13, 2023
@github-actions
Copy link

Try it on ⬅️ ReadTheDocs or Binder ➡️

@nrbgt nrbgt mentioned this pull request Sep 13, 2023
Closed
41 tasks
@nrbgt nrbgt marked this pull request as ready for review September 13, 2023 19:21
@nrbgt nrbgt requested a review from sanbales September 13, 2023 19:25
sanbales
sanbales reviewed Sep 13, 2023
View reviewed changes
src/ipyforcegraph/constants.py
"__indexColor",
"fx",
"fy",
"id",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need fz?

sanbales
sanbales approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@sanbales sanbales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only thing is not sure if we need fz in the RESERVED_COLUMNS

@nrbgt
Copy link
Contributor Author

nrbgt commented Sep 13, 2023

Pushed. Will go ahead and merge so we don't lose another hour.

@nrbgt nrbgt merged commit 6e73206 into jupyrdf:dev Sep 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanbales sanbales sanbales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nrbgt @sanbales