Create rejectWith Promises when mock is called #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 17, 2017 19:01
This test demonstrates that promises are created at configuration time and not when the mock is called. From docs: The 'rejectionHandled' event is emitted whenever a Promise has been rejected and an error handler was attached to it ... later than one turn of the Node.js event loop. ... The 'unhandledRejection' event is emitted whenever a Promise is rejected and no error handler is attached to the promise within a turn of the event loop. https://nodejs.org/api/process.html#process_event_rejectionhandled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
Since node 6.9, if a promise is rejected and no error handler is attached to the promise within a turn of the event loop, or if an error handler was attached to it later than one turn of the Node.js event loop, then warnings are logged (and in future versions of node it will terminate the node process).
Since
rejectWithcreates the promise when it is called, and not when the mock is called, this means that the following code will generate warnings:This PR demonstrates this by first adding a test, and then fixes it by create the rejected promise when the mock is called.