Update Timeline Component To Fix Provider Syntax #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this is a small mistake.
|
@ThatOneAwkwardGuy is attempting to deploy a commit to the junwenk's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@ThatOneAwkwardGuy Hello there, thanks so much for your contribution! 😄 You made a great catch — React 19 actually introduced this change to support using context as a provider directly. I think I may have missed updating some components — probably all the v4 components should be updated to use |
|
Ah i see, so is v4 specifically for react 19? haven't updated to that yet. |
|
You should split into 2 version, or should use Context.Provider to can use in both react 18 and react 19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is a small mistake.