don't modify settings on failure #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i don't merge this commit. other may need this setting |
|
I updated the popup text to include information on how to update their settings so they can choose to do so if they wish. |
|
@junstyle Who wants this feature? +1 to merge this PR to not modify settings because of failure, we are not working all the time on the same projects, etc. Sometimes we need to work on something else and then come back to the project and then, after the php-cs-fixer failure we have, the settings are refreshed and it doesn't work and we need to go to the settings and update them. Horrible! Please merge it, or we need some configuration to enable/disable this. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161