Added ability to authenticate with RiotClientUx #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @andrewchae, this looks great! Thank you so much. I'm in the process of moving so I am currently unable to test this patch. If you could confirm that everything works as expected that'd be greatly appreciated! |
junlarsen
reviewed
Aug 3, 2021
| @@ -74,6 +74,7 @@ LeagueClientUx process. If you wish to await until a client is found, you can us | |||
|
|
|||
| | Option | Default Value | Description | | |||
| |--------|---------------|-------------| | |||
| | name | `LeagueClientUx` | League Client name, set to RiotClientUx if you would like to authenticate with the Riot Client | |||
There was a problem hiding this comment.
Thank you so much for updating the documentation!
junlarsen
approved these changes
Aug 3, 2021
It's been working for me on Windows at least. I don't have the other environments set up. Thanks for merging! |
|
Thank you! I've bumped the version and tagged a new release as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.