Skip to content
This repository was archived by the owner on Jan 6, 2020. It is now read-only.

Allow changing the default logger implementation (#56) #65

Merged
merged 1 commit into from
Oct 12, 2019

Conversation

junlarsen
Copy link
Owner

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Simply replace any existing Client::setLogging(false) calls to Client::disableLogging()

The PR fulfills these requirements:

  • It's submitted to the development branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All PHPUnit tests are passing
  • New/updated tests are included (if applicable)

Other information:
Closes #56

@junlarsen junlarsen added the type:enhancement This issue is a new feature or request label Oct 12, 2019
@junlarsen junlarsen merged commit 5b1d9c3 into master Oct 12, 2019
@junlarsen junlarsen deleted the feature/custom-logger branch October 12, 2019 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:enhancement This issue is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging
1 participant