Skip to content
This repository was archived by the owner on Jan 6, 2020. It is now read-only.

Create timed cache (#60) #63

Merged
merged 3 commits into from
Oct 4, 2019
Merged

Create timed cache (#60) #63

merged 3 commits into from
Oct 4, 2019

Conversation

junlarsen
Copy link
Owner

@junlarsen junlarsen commented Oct 4, 2019

This PR introduces the ability to set a cache timer on Collection api calls. Example being

$summoner->getRanked(7200);

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the development branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All PHPUnit tests are passing
  • New/updated tests are included (if applicable)

Other information:
Closes #60

Documentation will be updated shortly

@junlarsen junlarsen changed the title Create timed cache Create timed cache (#60) Oct 4, 2019
@junlarsen junlarsen added the type:enhancement This issue is a new feature or request label Oct 4, 2019
@junlarsen junlarsen merged commit dea5243 into master Oct 4, 2019
@junlarsen junlarsen deleted the create-timed-cache branch October 4, 2019 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:enhancement This issue is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set ->getRanked() cache time
1 participant