Error (code 6) on "eune"

[WildEgo]

Describe the bug
When trying to set the region to eune I get thrown an error code 6

To Reproduce
Steps to reproduce the behavior:

1. LeagueApi::summoner('eune')->name($result->account_ign)
2. "ERROR (code 6): Specified region could not be resolved."

Expected behavior
I'm supposed to receive summoner information .

Desktop (please complete the following information):

• OS: Windows 10
• PHP Version: 7.2.10
• RiotQuest Version: 1.3.4

[junlarsen]

Hi, eune does currently not resolve into a valid region (https://github.com/supergrecko/RiotQuest/blob/master/src/RiotQuest/Components/Engine/Utils.php#L34)

I'll update it so it'll resolve.

[WildEgo]

Thanks could you do the same check up for the other regions? I'd really appreciate it that way in case it happens again I don't post here, also if you don't mind how can I handle exceptions? Since they're just throwing a complete error page instead of something I can work with

[junlarsen]

You can catch the LeagueException type. I'm going to create a more intuitive exception handling system for the next major release which will be a while after PHP 7.4's release.

Also, it seems like eune should already resolve, I'll have a deeper look

[WildEgo]

Sorry for being annoying but could you give me a snippet just to check if what I wrote is wrong or not (I'm using Laravel in case it helps)

[junlarsen]

Hello, this code snippet works perfectly fine for me on 1.3.4

dump(Client::summoner('eune', 1)->name('abc'));

And to answer your second question:

use RiotQuest\Contracts\LeagueException;

try {
    dump(Client::summoner('eune', 1)->name('abc'));
} catch (LeagueException $ex) {
    // deal with $ex
}

Is there anything on your end which could be breaking it or are you passing the literal 'eune' string?

[WildEgo]

Oh I think I found the problem the method ->getRanked() is the one throwing the exception it looks like

[junlarsen]

This has been resolved, you can grab it via 1.3.5