Skip to content

Move @TestFactory return type validation to discovery phase #4424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 28, 2025
Merged

Move @TestFactory return type validation to discovery phase #4424

merged 2 commits into from
Mar 28, 2025

Conversation

marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Mar 25, 2025 •
edited
Loading

Overview

Resolves #949.

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@marcphilipp marcphilipp self-assigned this Mar 25, 2025
@marcphilipp marcphilipp linked an issue Mar 25, 2025 that may be closed by this pull request
Move @TestFactory return type validation to IsTestFactoryMethod #949
Closed
2 tasks
@marcphilipp marcphilipp force-pushed the marc/949-test-factory-method-return-type-validation branch 2 times, most recently from ee6a830 to fcb21a3 Compare March 25, 2025 18:18
Base automatically changed from marc/242-critical-severity-config to main March 26, 2025 08:06
@marcphilipp marcphilipp force-pushed the marc/949-test-factory-method-return-type-validation branch from fcb21a3 to 3172eab Compare March 26, 2025 08:07
@marcphilipp marcphilipp force-pushed the marc/949-test-factory-method-return-type-validation branch from 3172eab to aca3004 Compare March 26, 2025 08:11
@marcphilipp marcphilipp marked this pull request as ready for review March 26, 2025 08:11
@marcphilipp marcphilipp changed the title Move @TestFactory return type validation to IsTestFactoryMethod Move @TestFactory return type validation to IsTestFactoryMethod Mar 28, 2025
@marcphilipp marcphilipp changed the title Move @TestFactory return type validation to IsTestFactoryMethod Move @TestFactory return type validation to discovery phase Mar 28, 2025
@marcphilipp marcphilipp merged commit c926afa into main Mar 28, 2025
13 checks passed
@marcphilipp marcphilipp deleted the marc/949-test-factory-method-return-type-validation branch March 28, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcphilipp marcphilipp

Labels
theme: diagnostics theme: discovery theme: dynamic tests type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move @TestFactory return type validation to IsTestFactoryMethod
1 participant
@marcphilipp