Add support for passing line and column number to ConsoleLauncher via --select-file and --select-resource
#4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,4 +120,12 @@ public DiscoverySelectorIdentifier convert(String value) { | |||
| } | |||
| } | |||
|
|
|||
| private static URI stripQueryComponent(URI uri) { | |||
There was a problem hiding this comment.
This method is a duplicate of the one in org.junit.platform.engine.support.descriptor.ResourceUtils, but I don't think there is a way of using the same in both places, is it?
There was a problem hiding this comment.
If we made ResourceUtils and the method public, we could reuse it. I think it would be slightly better regarding consistenct to move it to the org.junit.platform.commons.util package, though.
marcphilipp
reviewed
Oct 7, 2024
| @@ -109,4 +120,12 @@ public DiscoverySelectorIdentifier convert(String value) { | |||
| } | |||
| } | |||
|
|
|||
| private static URI stripQueryComponent(URI uri) { | |||
There was a problem hiding this comment.
If we made ResourceUtils and the method public, we could reuse it. I think it would be slightly better regarding consistenct to move it to the org.junit.platform.commons.util package, though.
junit-platform-commons/src/main/java/org/junit/platform/commons/util/ResourceUtils.java
Outdated
Show resolved
Hide resolved
marcphilipp
reviewed
Oct 11, 2024
junit-platform-commons/src/main/java/org/junit/platform/commons/util/ResourceUtils.java
Outdated
Show resolved
Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/util/ResourceUtils.java
Outdated
Show resolved
Hide resolved
… `--select-file` and `--select-resource`
juliette-derancourt
force-pushed
the
issues/3483-console-launcher-select-line-column
branch
from
f1bef61
to
a16ac63
Compare
juliette-derancourt
force-pushed
the
issues/3483-console-launcher-select-line-column
branch
from
a16ac63
to
7d2ed6d
Compare
marcphilipp
approved these changes
Oct 21, 2024
juliette-derancourt
deleted the
issues/3483-console-launcher-select-line-column
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #3483
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations