Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document best practices for implementing ParameterResolvers #3829

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

jabhatfield
Copy link
Contributor

@jabhatfield jabhatfield commented May 22, 2024

Issue: #1190

Overview

User guide updated to explain ParameterResolver conflicts and provide some ways to resolve them.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@marcphilipp marcphilipp linked an issue Jun 20, 2024 that may be closed by this pull request
2 tasks
@jabhatfield
Copy link
Contributor Author

Please could I get some feedback for this PR?

Copy link
Member

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! The new section does a good job at explaining why/when conflicts occur. However, it does not document the best practices mentioned in the issue description. For example, using a custom annotation and/or a custom parameter type. Could you please add that?

@jabhatfield
Copy link
Contributor Author

Sorry for the delay! The new section does a good job at explaining why/when conflicts occur. However, it does not document the best practices mentioned in the issue description. For example, using a custom annotation and/or a custom parameter type. Could you please add that?

Thanks for the feedback! I've added examples of using a custom type and a custom annotation.

@marcphilipp marcphilipp self-requested a review July 25, 2024 10:20
Copy link
Member

@marcphilipp marcphilipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think it's very thorough now! I polished it a bit but it was already in great shape. 👍

@marcphilipp marcphilipp changed the title Document parameter resolution conflicts Document best practices for implementing ParameterResolvers Jul 25, 2024
@marcphilipp marcphilipp merged commit 0ca1754 into junit-team:main Jul 25, 2024
16 checks passed
@marcphilipp
Copy link
Member

@jabhatfield Thank you for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document best practices for implementing ParameterResolvers
2 participants