-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document best practices for implementing ParameterResolvers #3829
Document best practices for implementing ParameterResolvers #3829
Conversation
Please could I get some feedback for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay! The new section does a good job at explaining why/when conflicts occur. However, it does not document the best practices mentioned in the issue description. For example, using a custom annotation and/or a custom parameter type. Could you please add that?
documentation/src/test/java/example/extensions/ParameterResolverNestedClasses.java
Outdated
Show resolved
Hide resolved
Issue: junit-team#1190
Thanks for the feedback! I've added examples of using a custom type and a custom annotation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think it's very thorough now! I polished it a bit but it was already in great shape. 👍
@jabhatfield Thank you for your contribution! 👍 |
Issue: #1190
Overview
User guide updated to explain
ParameterResolver
conflicts and provide some ways to resolve them.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations