-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce method filter support in the ConsoleLauncher #3169
Introduce method filter support in the ConsoleLauncher #3169
Conversation
We originally thought we didn't need an include filter because there's already a way to select particular methods. However, the latter does not allow specifying wildcards so there might be some use cases where it would be beneficial. Team decision: Add both |
documentation/src/docs/asciidoc/release-notes/release-notes-5.10.0-M1.adoc
Outdated
Show resolved
Hide resolved
@marcphilipp Thanks for the feedback, I've added the cli options. |
f03f888
to
2f26377
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid I caused a lot of merge conflicts by introducing subcommands in the ConsoleLauncher
recently. The new options should now be added to TestDiscoveryOptionsMixin.FilterOptions
instead.
@Sakieye Do you have time to rework the PR?
junit-platform-console/src/main/java/org/junit/platform/console/options/AvailableOptions.java
Outdated
Show resolved
Hide resolved
22210ca
to
2b90fd0
Compare
2b90fd0
to
bfc798b
Compare
@marcphilipp I've updated my PR, please help review again |
3fdbe6d
to
ba42ab9
Compare
@marcphilipp Do you still need this feature? If so, I can update it sometime soon. |
Yes, that'd be great if you're still interested! 👍 |
ba42ab9
to
fbfcb36
Compare
@marcphilipp I updated my PR again, please help review |
documentation/src/docs/asciidoc/release-notes/release-notes-5.12.0-M1.adoc
Outdated
Show resolved
Hide resolved
junit-platform-launcher/src/main/java/org/junit/platform/launcher/ExcludeMethodFilter.java
Show resolved
Hide resolved
junit-platform-launcher/src/main/java/org/junit/platform/launcher/IncludeMethodFilter.java
Show resolved
Hide resolved
junit-platform-launcher/src/main/java/org/junit/platform/launcher/MethodFilter.java
Show resolved
Hide resolved
platform-tests/src/test/java/org/junit/platform/console/ConsoleLauncherIntegrationTests.java
Outdated
Show resolved
Hide resolved
junit-platform-launcher/src/main/java/org/junit/platform/launcher/MethodFilter.java
Show resolved
Hide resolved
@yhkuo41 Thank you for your contribution! 👍 |
My pleasure 😀 |
Issue: #3107
Overview
Solves #3107.
After referring to other Filters (such as TagFilter), I am not sure if I should implement both IncludeMethodFilter and ExcludeMethodFilter, please let me know if I should remove IncludeMethodFilter.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations