Build with JDK-9 only #1097
Merged
Build with JDK-9 only #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JUnit 5 build requires JDK-9 or higher. The JUnit 5 runtime environment needs to be Java 8 or higher. Travis CI now sets "-Xmx" by default.
ghost
assigned 
marcphilipp
reviewed
Oct 8, 2017
| @@ -126,13 +126,12 @@ allprojects { subproj -> | |||
| } | |||
|
|
|||
| tasks.withType(JavaCompile) { | |||
| sourceCompatibility = rootProject.sourceCompatibility | |||
| targetCompatibility = rootProject.targetCompatibility | |||
There was a problem hiding this comment.
I think we should keep specifying source and target.
There was a problem hiding this comment.
javac does not allow this:
Execution failed for task ':junit-platform-commons:compileJava'.
> option -source cannot be used together with --release
When added to compilerArgs via:
// See: https://docs.oracle.com/javase/9/tools/javac.htm#JSWOR627
compileJava.options*.compilerArgs = [
'--release', rootProject.javacRelease,
'-source', rootProject.javacRelease,
'-target', rootProject.javacRelease,
...
There was a problem hiding this comment.
But our build refers to compileJava.sourceCompatibility here and there. Like in cloverInstrumentJava around line 224: source: compileJava.sourceCompatibility) {.
18 tasks
marcphilipp
approved these changes
Oct 9, 2017
| @@ -0,0 +1,10 @@ | |||
| build: off | |||
There was a problem hiding this comment.
Enables the build.
No kidding.
It disables the automatic search and execution of a "build script thing".
See: https://www.appveyor.com/docs/build-phase/
Ref: https://www.appveyor.com/docs/appveyor-yml/
Andrei94
pushed a commit
to Andrei94/junit5
that referenced
this pull request
Jun 23, 2018
* Use --release 8 option from JDK 9 javac * Remove matrix and special java options from Travis CI The JUnit 5 build requires JDK-9 or higher. The JUnit 5 runtime environment needs to be Java 8 or higher. Travis CI now sets "-Xmx" by default. * Switch Javadoc step to use JDK 9 * Switch AsciiDoc step to use JDK 9 w/o PDF backend See jruby/jruby#4805 * Fix Clover instrumentation * Add custom AppVeyor script to install JDK-9 * Add JDK9-compatible Javadoc stylesheet * Fix Javadoc @value tag usages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove JDK build matrix on Travis CI and use
--release 8javac option.The JUnit 5 build requires JDK-9 or higher.
The JUnit 5 runtime environment needs to be Java 8 or higher.
Travis CI now sets "-Xmx" by default.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations