Skip to content

Commit

Permalink
Use nohttp plugin in Gradle build
Browse files Browse the repository at this point in the history
Closes #1923
  • Loading branch information
sbrannen committed Jun 16, 2019
1 parent c56da15 commit a94af23
Show file tree
Hide file tree
Showing 53 changed files with 87 additions and 71 deletions.
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ I hereby agree to the terms of the [JUnit Contributor License Agreement](https:/
### Definition of Done

- [ ] There are no TODOs left in the code
- [ ] Method [preconditions](http://junit.org/junit5/docs/snapshot/api/org/junit/platform/commons/util/Preconditions.html) are checked and documented in the method's Javadoc
- [ ] Method [preconditions](https://junit.org/junit5/docs/snapshot/api/org/junit/platform/commons/util/Preconditions.html) are checked and documented in the method's Javadoc
- [ ] [Coding conventions](https://github.com/junit-team/junit5/blob/master/CONTRIBUTING.md#coding-conventions) (e.g. for logging) have been followed
- [ ] Change is covered by [automated tests](https://github.com/junit-team/junit5/blob/master/CONTRIBUTING.md#tests) including corner cases, errors, and exception handling
- [ ] Public API has [Javadoc](https://github.com/junit-team/junit5/blob/master/CONTRIBUTING.md#javadoc) and [`@API` annotations](https://apiguardian-team.github.io/apiguardian/docs/current/api/org/apiguardian/api/API.html)
- [ ] Change is documented in the [User Guide](http://junit.org/junit5/docs/snapshot/user-guide/) and [Release Notes](http://junit.org/junit5/docs/snapshot/user-guide/#release-notes)
- [ ] Change is documented in the [User Guide](https://junit.org/junit5/docs/snapshot/user-guide/) and [Release Notes](https://junit.org/junit5/docs/snapshot/user-guide/#release-notes)
- [ ] All [continuous integration builds](https://github.com/junit-team/junit5#continuous-integration-builds) pass
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
## Commit Messages

As a general rule, the style and formatting of commit messages should follow the guidelines in
[How to Write a Git Commit Message](http://chris.beams.io/posts/git-commit/).
[How to Write a Git Commit Message](https://chris.beams.io/posts/git-commit/).

In addition, any commit that is related to an existing issue must reference the issue.
For example, if a commit in a pull request addresses issue \#999, it must contain the
Expand Down Expand Up @@ -118,8 +118,8 @@ In multi-line bullet point entries, subsequent lines should be indented.
### Logging

- In general, logging should be used sparingly.
- All logging must be performed via the internal `Logger` façade provided via the JUnit [LoggerFactory](http://junit.org/junit5/docs/current/api/org/junit/platform/commons/logging/LoggerFactory.html).
- Levels defined in JUnit's [Logger](http://junit.org/junit5/docs/current/api/org/junit/platform/commons/logging/Logger.html) façade.
- All logging must be performed via the internal `Logger` façade provided via the JUnit [LoggerFactory](https://junit.org/junit5/docs/current/api/org/junit/platform/commons/logging/LoggerFactory.html).
- Levels defined in JUnit's [Logger](https://junit.org/junit5/docs/current/api/org/junit/platform/commons/logging/Logger.html) façade.
- _error_ (JUL: `SEVERE`, Log4J: `ERROR`): extra information (in addition to an Exception) about errors that will halt execution
- _warn_ (JUL: `WARNING`, Log4J: `WARN`): potential usage or configuration errors that should not halt execution
- _info_ (JUL: `INFO`, Log4J: `INFO`): information the users might want to know but not by default
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ See also <https://repo1.maven.org/maven2/org/junit/> for releases and <https://o
[CONTRIBUTING.md]: https://github.com/junit-team/junit5/blob/master/CONTRIBUTING.md
[Gitter]: https://gitter.im/junit-team/junit5
[Gradle Wrapper]: https://docs.gradle.org/current/userguide/gradle_wrapper.html#sec:using_wrapper
[JaCoCo]: http://www.eclemma.org/jacoco/
[JaCoCo]: https://www.eclemma.org/jacoco/
[Javadoc]: https://junit.org/junit5/docs/current/api/
[JDK 11]: https://jdk.java.net/11/
[Release Notes]: https://junit.org/junit5/docs/current/release-notes/
Expand Down
9 changes: 8 additions & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ plugins {
id("com.github.ben-manes.versions") // gradle dependencyUpdates
id("com.diffplug.gradle.spotless")
id("de.marcphilipp.nexus-publish") apply false
id("io.spring.nohttp") version "0.0.2.RELEASE"
}

buildScan {
Expand Down Expand Up @@ -49,7 +50,7 @@ val modularProjects by extra(mavenizedProjects - listOf(project(":junit-platform

val license by extra(License(
name = "Eclipse Public License v2.0",
url = uri("http://www.eclipse.org/legal/epl-v20.html"),
url = uri("https://www.eclipse.org/legal/epl-v20.html"),
headerFile = file("src/spotless/eclipse-public-license-2.0.java")
))

Expand Down Expand Up @@ -164,6 +165,12 @@ rootProject.apply {
}
}

nohttp {
// The following doesn't compile with the Kotlin DSL.
// source.exclude("**/buildSrc/build/**/kotlin-dsl*/**")
whitelistFile = project.file("src/nohttp/whitelist.lines")
}

tasks {
dependencyUpdates {
resolutionStrategy {
Expand Down
4 changes: 2 additions & 2 deletions documentation/src/docs/asciidoc/tocbot-3.0.2/tocbot.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion documentation/src/docs/asciidoc/user-guide/index.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Stefan Bechtold; Sam Brannen; Johannes Link; Matthias Merdes; Marc Philipp; Chri
//
ifdef::backend-pdf[:imagesdir: {imagesoutdir}]
//
// Blank lines are not permitted in the doc-header: http://asciidoctor.org/docs/user-manual/#doc-header
// Blank lines are not permitted in the doc-header: https://asciidoctor.org/docs/user-manual/#doc-header
//
:sectnums:
:toclevels: 4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ native support instead.

Starting with https://issues.apache.org/jira/browse/SUREFIRE-1330[version 2.22.0], Maven
Surefire and Maven Failsafe provide
http://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html[native support]
https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html[native support]
for executing tests on the JUnit Platform. The `pom.xml` file in the
`{junit5-jupiter-starter-maven}` project demonstrates how to use the Maven Surefire plugin
and can serve as a starting point for configuring your Maven build.
Expand Down
8 changes: 4 additions & 4 deletions documentation/src/docs/asciidoc/user-guide/writing-tests.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,9 @@ are therefore free to use the assertion library of their choice.
For example, the combination of _matchers_ and a fluent API can be used to make
assertions more descriptive and readable. However, JUnit Jupiter's `{Assertions}` class
does not provide an
http://junit.org/junit4/javadoc/latest/org/junit/Assert.html#assertThat[`assertThat()`]
https://junit.org/junit4/javadoc/latest/org/junit/Assert.html#assertThat[`assertThat()`]
method like the one found in JUnit 4's `org.junit.Assert` class which accepts a Hamcrest
http://junit.org/junit4/javadoc/latest/org/hamcrest/Matcher.html[`Matcher`]. Instead,
https://junit.org/junit4/javadoc/latest/org/hamcrest/Matcher.html[`Matcher`]. Instead,
developers are encouraged to use the built-in support for matchers provided by third-party
assertion libraries.

Expand Down Expand Up @@ -1280,8 +1280,8 @@ integral types: `byte`, `short`, `int`, `long`, and their boxed counterparts.
| `java.lang.Class` | `"char[]"` -> `char[].class` _(array types are supported)_
| `java.math.BigDecimal` | `"123.456e789"` -> `new BigDecimal("123.456e789")`
| `java.math.BigInteger` | `"1234567890123456789"` -> `new BigInteger("1234567890123456789")`
| `java.net.URI` | `"http://junit.org/"` -> `URI.create("http://junit.org/")`
| `java.net.URL` | `"http://junit.org/"` -> `new URL("http://junit.org/")`
| `java.net.URI` | `"https://junit.org/"` -> `URI.create("https://junit.org/")`
| `java.net.URL` | `"https://junit.org/"` -> `new URL("https://junit.org/")`
| `java.nio.charset.Charset` | `"UTF-8"` -> `Charset.forName("UTF-8")`
| `java.nio.file.Path` | `"/path/to/file"` -> `Paths.get("/path/to/file")`
| `java.time.Duration` | `"PT3S"` -> `Duration.ofSeconds(3)`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public void beforeAll(ExtensionContext context) {
}

public String getServerUrl() {
return "http://example.org:8181";
return "https://example.org:8181";
}

public static Builder builder() {
Expand Down
2 changes: 1 addition & 1 deletion gradlew
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
Expand Down
2 changes: 1 addition & 1 deletion gradlew.bat
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
@rem you may not use this file except in compliance with the License.
@rem You may obtain a copy of the License at
@rem
@rem http://www.apache.org/licenses/LICENSE-2.0
@rem https://www.apache.org/licenses/LICENSE-2.0
@rem
@rem Unless required by applicable law or agreed to in writing, software
@rem distributed under the License is distributed on an "AS IS" BASIS,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
*
* @return script engine name
* @see javax.script.ScriptEngineManager#getEngineByName(String)
* @see <a href="http://www.oracle.com/technetwork/articles/java/jf14-nashorn-2126515.html">Oracle Nashorn</a>
* @see <a href="https://www.oracle.com/technetwork/articles/java/jf14-nashorn-2126515.html">Oracle Nashorn</a>
*/
String engine() default "Nashorn";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@
*
* @return script engine name
* @see javax.script.ScriptEngineManager#getEngineByName(String)
* @see <a href="http://www.oracle.com/technetwork/articles/java/jf14-nashorn-2126515.html">Oracle Nashorn</a>
* @see <a href="https://www.oracle.com/technetwork/articles/java/jf14-nashorn-2126515.html">Oracle Nashorn</a>
*/
String engine() default "Nashorn";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* made available under the terms of the Eclipse Public License v2.0 which
* accompanies this distribution and is available at
*
* http://www.eclipse.org/legal/epl-v20.html
* https://www.eclipse.org/legal/epl-v20.html
*/
package org.junit.jupiter.api

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* made available under the terms of the Eclipse Public License v2.0 which
* accompanies this distribution and is available at
*
* http://www.eclipse.org/legal/epl-v20.html
* https://www.eclipse.org/legal/epl-v20.html
*/
package org.junit.jupiter.api

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* made available under the terms of the Eclipse Public License v2.0 which
* accompanies this distribution and is available at
*
* http://www.eclipse.org/legal/epl-v20.html
* https://www.eclipse.org/legal/epl-v20.html
*/
package org.junit.jupiter.api

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ void defaultUriSourceFromUri() {
File file = new File("src/test/resources");
assertThat(file).isDirectory();

URI uri = URI.create("http://example.com?foo=bar&line=42");
URI uri = URI.create("https://example.com?foo=bar&line=42");
TestSource testSource = TestFactoryTestDescriptor.fromUri(uri);

assertThat(testSource).isInstanceOf(UriSource.class);
Expand Down
2 changes: 1 addition & 1 deletion junit-jupiter-params/LICENSE-univocity-parsers.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Apache License
==============

_Version 2.0, January 2004_
_&lt;<http://www.apache.org/licenses/>&gt;_
_&lt;<https://www.apache.org/licenses/>&gt;_

### Terms and Conditions for use, reproduction, and distribution

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
* <ul>
* <li>The standard collections</li>
* <li>Tuples from third-party libraries, e.g.,
* <a href="http://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/tuple/package-summary.html">Commons Lang</a>,
* <a href="https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/tuple/package-summary.html">Commons Lang</a>,
* or <a href="https://www.javatuples.org">javatuples</a></li>
* <li>Your own data class</li>
* </ul>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,12 +171,13 @@ void convertsStringToBigInteger() {

@Test
void convertsStringToURI() {
assertConverts("http://java.sun.com/j2se/1.3/", URI.class, URI.create("http://java.sun.com/j2se/1.3/"));
assertConverts("https://docs.oracle.com/en/java/javase/12/", URI.class,
URI.create("https://docs.oracle.com/en/java/javase/12/"));
}

@Test
void convertsStringToURL() throws Exception {
assertConverts("http://junit.org/junit5", URL.class, new URL("http://junit.org/junit5"));
assertConverts("https://junit.org/junit5", URL.class, new URL("https://junit.org/junit5"));
}

// --- java.time -----------------------------------------------------------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ tasks {
"Engine-Version-junit-jupiter" to jupiterVersion,
"Engine-Version-junit-vintage" to vintageVersion,
// Version-aware binaries are already included - set Multi-Release flag here.
// See http://openjdk.java.net/jeps/238 for details
// See https://openjdk.java.net/jeps/238 for details
// Note: the "jar --update ... --release X" command does not work with the
// shadowed JAR as it contains nested classes that do comply multi-release jars.
"Multi-Release" to true
Expand Down
4 changes: 2 additions & 2 deletions junit-platform-console/LICENSE-picocli.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Apache License
==============

_Version 2.0, January 2004_
_&lt;<http://www.apache.org/licenses/>&gt;_
_&lt;<https://www.apache.org/licenses/>&gt;_

### Terms and Conditions for use, reproduction, and distribution

Expand Down Expand Up @@ -185,7 +185,7 @@ third-party archives.
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0
https://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
* <p>Tag expressions are boolean expressions with the following allowed
* operators: {@code !} (not), {@code &} (and), and {@code |} (or). Parentheses
* can be used to adjust for operator precedence. Please refer to the
* <a href="http://junit.org/junit5/docs/current/user-guide/#running-tests-tag-expressions">JUnit 5 User Guide</a>
* <a href="https://junit.org/junit5/docs/current/user-guide/#running-tests-tag-expressions">JUnit 5 User Guide</a>
* for usage examples.
*
* <p>Please note that a tag name is a valid tag expression. Thus, wherever a tag
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
* <p>Tag expressions are boolean expressions with the following allowed
* operators: {@code !} (not), {@code &} (and) and {@code |} (or). Parentheses
* can be used to adjust for operator precedence. Please refer to the
* <a href="http://junit.org/junit5/docs/current/user-guide/#running-tests-tag-expressions">JUnit 5 User Guide</a>
* <a href="https://junit.org/junit5/docs/current/user-guide/#running-tests-tag-expressions">JUnit 5 User Guide</a>
* for usage examples.
*
* <h3>Syntax Rules for Tags</h3>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
* <p>Tag expressions are boolean expressions with the following allowed
* operators: {@code !} (not), {@code &} (and) and {@code |} (or). Parentheses
* can be used to adjust for operator precedence. Please refer to the
* <a href="http://junit.org/junit5/docs/current/user-guide/#running-tests-tag-expressions">JUnit 5 User Guide</a>
* <a href="https://junit.org/junit5/docs/current/user-guide/#running-tests-tag-expressions">JUnit 5 User Guide</a>
* for usage examples.
*
* <h3>Syntax Rules for Tags</h3>
Expand Down
2 changes: 1 addition & 1 deletion platform-tests/platform-tests.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies {
}
testRuntimeOnly(localGroovy()) // because `ReflectionUtilsTests.findNestedClassesWithInvalidNestedClassFile` needs it

// --- http://openjdk.java.net/projects/code-tools/jmh/ -----------------------
// --- https://openjdk.java.net/projects/code-tools/jmh/ -----------------------
jmh("org.openjdk.jmh:jmh-core:${Versions.jmh}") {
exclude(module = "jopt-simple")
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ void parseValidUriSelectors(ArgsType type) {
() -> assertEquals(singletonList(new URI("file:///foo.txt")), type.parseArgLine("-select-uri=file:///foo.txt").getSelectedUris()),
() -> assertEquals(singletonList(new URI("file:///foo.txt")), type.parseArgLine("--select-uri file:///foo.txt").getSelectedUris()),
() -> assertEquals(singletonList(new URI("file:///foo.txt")), type.parseArgLine("--select-uri=file:///foo.txt").getSelectedUris()),
() -> assertEquals(asList(new URI("file:///foo.txt"), new URI("http://localhost")), type.parseArgLine("-u file:///foo.txt -u http://localhost").getSelectedUris())
() -> assertEquals(asList(new URI("file:///foo.txt"), new URI("https://example")), type.parseArgLine("-u file:///foo.txt -u https://example").getSelectedUris())
);
// @formatter:on
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ void selectUriByName() {
assertThrows(PreconditionViolationException.class, () -> selectUri(" "));
assertThrows(PreconditionViolationException.class, () -> selectUri("foo:"));

String uri = "http://junit.org";
String uri = "https://junit.org";

UriSelector selector = selectUri(uri);
assertEquals(uri, selector.getUri().toString());
Expand All @@ -70,7 +70,7 @@ void selectUriByURI() throws Exception {
assertThrows(PreconditionViolationException.class, () -> selectUri((URI) null));
assertThrows(PreconditionViolationException.class, () -> selectUri(" "));

URI uri = new URI("http://junit.org");
URI uri = new URI("https://junit.org");

UriSelector selector = selectUri(uri);
assertEquals(uri, selector.getUri());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ class UriSelectorTests extends AbstractEqualsAndHashCodeTests {

@Test
void equalsAndHashCode() throws Exception {
var selector1 = new UriSelector(new URI("http://junit.org"));
var selector2 = new UriSelector(new URI("http://junit.org"));
var selector3 = new UriSelector(new URI("http://example.org"));
var selector1 = new UriSelector(new URI("https://junit.org"));
var selector2 = new UriSelector(new URI("https://junit.org"));
var selector3 = new UriSelector(new URI("https://example.org"));

assertEqualsAndHashCode(selector1, selector2, selector3);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* made available under the terms of the Eclipse Public License v2.0 which
* accompanies this distribution and is available at
*
* http://www.eclipse.org/legal/epl-v20.html
* https://www.eclipse.org/legal/epl-v20.html
*/

package com.example.project;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* made available under the terms of the Eclipse Public License v2.0 which
* accompanies this distribution and is available at
*
* http://www.eclipse.org/legal/epl-v20.html
* https://www.eclipse.org/legal/epl-v20.html
*/

package com.example.project;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* made available under the terms of the Eclipse Public License v2.0 which
* accompanies this distribution and is available at
*
* http://www.eclipse.org/legal/epl-v20.html
* https://www.eclipse.org/legal/epl-v20.html
*/

package com.example.project
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* made available under the terms of the Eclipse Public License v2.0 which
* accompanies this distribution and is available at
*
* http://www.eclipse.org/legal/epl-v20.html
* https://www.eclipse.org/legal/epl-v20.html
*/

import static org.junit.jupiter.api.Assertions.fail;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* made available under the terms of the Eclipse Public License v2.0 which
* accompanies this distribution and is available at
*
* http://www.eclipse.org/legal/epl-v20.html
* https://www.eclipse.org/legal/epl-v20.html
*/

package com.example.project;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* made available under the terms of the Eclipse Public License v2.0 which
* accompanies this distribution and is available at
*
* http://www.eclipse.org/legal/epl-v20.html
* https://www.eclipse.org/legal/epl-v20.html
*/

package com.example.project;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>platform.tooling.support.tests</groupId>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>com.example</groupId>
Expand Down
Loading

2 comments on commit a94af23

@jbduncan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sormuras
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Please sign in to comment.