Remove unused constructors in the external AssumptionViolatedException. #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @DataPoint | ||
| public static Matcher<?> IS_THREE = is(3); | ||
| public static Matcher<Integer> IS_THREE = is(3); | ||
|
|
||
| @DataPoint | ||
| public static Matcher<?> NULL = null; |
There was a problem hiding this comment.
I think this should be Matcher<Integer>, too. Even though the current Theories implementation will not take the type parameter into account.
kcooney
force-pushed
the
AssumptionViolatedException-remove-unused-ctors
branch
from
30efd9a
to
fdc4374
Compare
|
I am going to wait until #994 is merged, then rebase this pull before merging. |
kcooney
force-pushed
the
AssumptionViolatedException-remove-unused-ctors
branch
from
fdc4374
to
d0b029f
Compare
|
Merged in changes from #994 and rebased. PTAL |
marcphilipp
added a commit
that referenced
this pull request
Sep 24, 2014
…ve-unused-ctors Remove unused constructors in the external AssumptionViolatedException.
|
Thanks! |
|
Thanks for reviewing! I owe you an update to the release notes |
|
What do you want to update in the release notes? |
|
@marcphilipp just sent out #999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused constructors in the external AssumptionViolatedException.
Rename fields of internal AssumptionViolatedException so we don't break serialization with JUnit 4.11