Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring no-generic-type-parms validator called/tested for theories #572

Merged
merged 1 commit into from
Dec 13, 2012
Merged

Ensuring no-generic-type-parms validator called/tested for theories #572

merged 1 commit into from
Dec 13, 2012

Conversation

pholser
Copy link
Contributor

@pholser pholser commented Dec 12, 2012

No description provided.

public static void main(String[] args) {
System.out.println(id());
}
public static String id() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my information, did you make this change by hand, or automatically by running ant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By running ant.

dsaff pushed a commit that referenced this pull request Dec 13, 2012
Ensuring no-generic-type-parms validator called/tested for theories
@dsaff dsaff merged commit 1b7312e into junit-team:master Dec 13, 2012
@dsaff
Copy link
Member

dsaff commented Dec 13, 2012

Thanks! Could you perhaps put a note on the release notes at https://github.com/KentBeck/junit/wiki/4.12-release-notes ?

@pholser
Copy link
Contributor Author

pholser commented Dec 13, 2012

Done!

@quenio
Copy link

quenio commented Oct 21, 2015

It's really unfortunate that 4.12 no longer supports generic params on theory methods.

There are some generic tests, such as CompareToTheory<T extends Comparable<T>> that are no longer supported. See: https://www.smartics.eu/smartics-test-utils/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants