-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle AssumptionViolatedException in @Parameters method #1460
Merged
kcooney
merged 8 commits into
junit-team:master
from
panchenko:assumptionViolationInParameters
Jun 14, 2017
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3bc3a3a
Handle AssumptionViolatedException in @Parameters method
panchenko 3b51961
style
panchenko dbea385
improve test
panchenko 03987d9
move catch
panchenko 32abe67
Make RunnersFactory's fields final again.
kcooney 4f6c1fb
no need initializing with null
panchenko caa4706
test both flows
panchenko a59537e
style
panchenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't you catch this exception in the caller (
RunnersFactory
)? If the exception gets caught, you can set a field inRunnersFactory
namedrunnerOverride
to a newAssumptionViolationRunner
. IfrunnerOverride
is set it would be returned fromRunnersFactory.createRunners()
.As a bonus, we could possibly catch any exception from there, and for the exceptions that aren't
AssumptionViolatedException
useErrorReportingRunner
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've implemented the first part.
ErrorReportingRunner
is already applied inRunnerBuilder.safeRunnerForClass()
, seems like we should not care about other exceptions.