Skip to content

Disable Picocli's usage help auto width computation #3423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Disable Picocli's usage help auto width computation #3423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
55b4193
Disable Picocli's usage help auto width computation
sormuras Aug 11, 2023
9ba173f
Require terminal to be present when determine console's charset
sormuras Aug 18, 2023
b61b13f
Spotless
sormuras Aug 18, 2023
a034d97
Invoke method on non-null console object
sormuras Aug 18, 2023
cd2a133
Simplify assertion
sormuras Aug 18, 2023
bc96713
Disable ANSI colors
sormuras Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion junit-platform-console/src/main/java/org/junit/platform/console/options/MainCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
sortOptions = false, //
usageHelpWidth = 95, //
showAtFileInUsageHelp = true, //
usageHelpAutoWidth = true, //
usageHelpAutoWidth = false, // https://github.com/remkop/picocli/issues/1104
description = "Launches the JUnit Platform for test discovery and execution.", //
footerHeading = "%n", //
footer = "For more information, please refer to the JUnit User Guide at%n" //
Expand Down
3 changes: 1 addition & 2 deletions platform-tests/src/test/java/org/junit/platform/console/ConsoleLauncherTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ void displayBanner(String command) {
var consoleLauncher = new ConsoleLauncher(ConsoleTestExecutor::new, printSink, printSink);
consoleLauncher.run(command);

assertThat(stringWriter.toString()).contains(
"Thanks for using JUnit! Support its development at https://junit.org/sponsoring");
assertThat(stringWriter.toString()).contains("Thanks for using JUnit!");
}

@ParameterizedTest(name = "{0}")
Expand Down
2 changes: 1 addition & 1 deletion ...m-tooling-support-tests/src/test/java/platform/tooling/support/tests/StandaloneTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ void listAllObservableEngines() {
.setTool(new Java()) //
.setProject("standalone") //
.addArguments("-jar", MavenRepo.jar("junit-platform-console-standalone")) //
.addArguments("engines", "--disable-banner").build() //
.addArguments("engines", "--disable-ansi-colors", "--disable-banner").build() //
.run(false);

assertEquals(0, result.getExitCode(), String.join("\n", result.getOutputLines("out")));
Expand Down