Status quo for selecting @TestTemplate or @TestFactory invocations by Unique ID

[sbrannen]

Overview

This issue is a prerequisite for #1025.

Implementation Notes

• Update JavaElementsResolver.resolveUniqueId(TestDescriptor, List<Segment>) so that it returns the number of resolved segments instead of a boolean and then check that all segments were resolved in JavaElementsResolver.resolveUniqueId(UniqueId) in order to determine what information to include in the log message.

Deliverables

• Test the status quo for selecting @TestTemplate and @TestFactory invocations by Unique ID.
  • See DiscoverySelectorResolverTests.
• Update the warning logged by JavaElementsResolver.resolveUniqueId() so that it informs the user that the Unique ID could only be partially resolved and that all test template invocations or dynamic tests will be executed.
  • See Implementation Notes.

[sbrannen]

in progress

[sbrannen]

FYI: the following test methods in DiscoverySelectorResolverTests are in place to verify the status quo.

• testFactoryMethodResolutionByUniqueId()
• testTemplateMethodResolutionByUniqueId()
• resolvingDynamicTestByUniqueIdResolvesOnlyUpToParentTestFactory()
• resolvingTestTemplateInvocationByUniqueIdResolvesOnlyUpToParentTestTemplate()

[sbrannen]

Log warnings for partial resolution now result in output similar to the following.

WARN  ...JavaElementsResolver - Unique ID '[engine:junit-jupiter]/[class:org.junit.jupiter.engine.discovery.DiscoverySelectorResolverTests2$MyTestClass]/[test-factory:dynamicTest()]/[dynamic-test:#1]' could only be partially resolved; failed to resolve the following segments: [Segment [type = 'dynamic-test', value = '#1']]

WARN  ...JavaElementsResolver - Unique ID '[engine:junit-jupiter]/[class:org.junit.jupiter.engine.discovery.DiscoverySelectorResolverTests2$TestClassWithTemplate]/[test-template:testTemplate()]/[test-template-invocation:#1]' could only be partially resolved; failed to resolve the following segments: [Segment [type = 'test-template-invocation', value = '#1']]

[sbrannen]

Latest, updated version of log warnings with additional information.

WARN  ...JavaElementsResolver - Unique ID '[engine:junit-jupiter]/[class:org.junit.jupiter.engine.discovery.MyTestClass]/[test-factory:dynamicTest()]/[dynamic-test:#1]' could only be partially resolved. All resolved segments will be executed; however, the following segments could not be resolved: [Segment [type = 'dynamic-test', value = '#1']]

WARN  ...JavaElementsResolver - Unique ID '[engine:junit-jupiter]/[bogus:enigma]' could not be resolved.

WARN  ...JavaElementsResolver - Unique ID '[engine:junit-jupiter]/[class:org.junit.jupiter.engine.discovery.TestClassWithTemplate]/[test-template:testTemplate()]/[test-template-invocation:#1]' could only be partially resolved. All resolved segments will be executed; however, the following segments could not be resolved: [Segment [type = 'test-template-invocation', value = '#1']]

[marcphilipp]

👍

[sbrannen]

Resolved in master in b9813b7 and 2791365.