-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gradle Wrapper 8.5 to 8.7 #807
Conversation
Hm Jackson should already been buildable with the moditec file (FasterXML/jackson-databind#2273) which is labeled as implemented in 2.10 (we are using 2.14) 🤔 |
@Bukama @Michael1993 fixing the aforementioned warning isn't straightforward (at least I don't get it right now). However, it is a warning and only becomes an error in Gradle 9.x. Meanwhile, I updated to Gradle 8.10.1 locally, and the build passes. We would then get Java 23 support, which would allow us to extend the CI build. I suggest:
WDYT? |
I think this is a valid consideration - let's do it this way. I think we might even get an easier migration to 9 then. |
Since 21 is no longer available for download (and is also no longer experimental…).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update!
At the moment, the build causes a new warning because of:
https://docs.gradle.org/current/userguide/upgrading_version_8.html#deprecate_register_feature_main_source_set
I first have to read through this, which is why I marked this PR as a draft. Simply doing the changes suggested in the Gradle docs:
Yields 2 errors due to our modular setup:
Proposed commit message:
PR checklist
The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.
Documentation (general)
.adoc
file in thedocs
folder, e.g.docs/report-entries.adoc
.adoc
file references demo insrc/demo/java
instead of containing code blocks as text.adoc
files)Documentation (new extension)
docs/docs-nav.yml
navigation has an entry for the new extensionpackage-info.java
contains information about the new extensionCode (general)
Code (new package)
module-info.java
module-info.java
Contributing
README.adoc
mentions the new contribution (real name optional)