Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: add ubuntu xenial and bionic #867

Merged
merged 1 commit into from
Aug 17, 2019

Conversation

janlazo
Copy link
Contributor

@janlazo janlazo commented Aug 10, 2019

Ubuntu Trusty reached EOL since April 2019.

Close #176

.travis.yml Outdated Show resolved Hide resolved
@janlazo janlazo force-pushed the travis-xenial branch 2 times, most recently from eaa4259 to b8c1d1d Compare August 13, 2019 01:41
@janlazo janlazo changed the title Travis: upgrade to ubuntu xenial Travis: add ubuntu xenial and bionic Aug 13, 2019
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@janlazo
Copy link
Contributor Author

janlazo commented Aug 13, 2019

is $ENV hack to detect vim 8 still needed in test.vader? I don't know what it's suppose to do. Isn't v:version or has('patch-8') enough for version detection?

@junegunn
Copy link
Owner

I guess the purpose of the ENV hack was to test Ruby or Python installer even on Vim 8.

vim-plug/test/test.vader

Lines 21 to 23 in 226d6ab

if $ENV != 'vim8'
call add(patch, 'let s:vim8 = 0')
endif

That was when the job feature of Vim 8 was new, unstable, and not widely available. Three years later, it doesn't make much sense to test Ruby/Python installers with Vim 8 anymore.

So basically we need to test:

  1. with Vim 8 or later (nightly)
  2. with Neovim
  3. with Vim 7.x for Ruby installer
  4. with Vim 7.x for Python installer
  5. with Vim 7.x for Python3 installer

janlazo added a commit to janlazo/vim-plug that referenced this pull request Aug 15, 2019
janlazo added a commit to janlazo/vim-plug that referenced this pull request Aug 15, 2019
.travis.yml Outdated Show resolved Hide resolved
Travis defaults to it since this year.
Ubuntu trusty reached EOL since April 2019.
Ubuntu bionic provides Vim 8.

Simplify OS install with Travis' apt addon
so that only Vim nightly will be compiled from source.

Ubuntu 14.04.6 provides ruby v.1.9.3, not 1.8.x or older.
Use it to test the ruby provider for backward compatibility.

Signed-off-by: Jan Edmund Lazo <jan.lazo@mail.utoronto.ca>
@junegunn junegunn merged commit 307b0f2 into junegunn:master Aug 17, 2019
@junegunn
Copy link
Owner

Thanks!

@janlazo janlazo deleted the travis-xenial branch August 17, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis Spends Most Time Building Vim
2 participants