-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow command modifiers for on-demand-loading commands #1110
base: master
Are you sure you want to change the base?
Conversation
Before this commit, commands like this - :tab Git diff HEAD^ HEAD were interpreted like this - :Git diff HEAD^ HEAD This commit fixes that issue.
I think this needs a version guard because |
@tomtomjhj 2016 is relatively new? For whom? TBH, I'd completely forgotten about this PR 😅 |
Of course, I believe 2016 feature is old enough to use without version check in 2021. |
I'm one of those people with old Vim versions so add a version,feature checks until @junegunn changes his mind on the minimum Vim/Neovim versions. |
@janlazo Will do (please wait a few days, I am currently AFK). I am curious about why you are still using such an old version of vim. |
One of the strong selling points of vim-plug is its excellent backward compatibility. Most of its features work as expected even with Vim 7.0 which means that it works virtually everywhere. There can be various reasons you can't or won't use the latest versions of Vim (company guidelines, security requirements, systems with tiny resources, etc.), and still, you don't have to worry about vim-plug not working. That's a great thing and we're not going to lose that. |
@subnut Old company servers. Difficult to install or upgrade dev packages, even if it's just a newer version of Vim. Some of my colleagues don't know or care that vi,vim, |
Tried implementing the version guard in 82ffd4f |
Before this commit, commands like this -
were interpreted like this -
:Git diff HEAD^ HEAD
This commit fixes that issue.