Executes fzf from fzf-tmux with a process name

[richiware]

This is a little improvement useful for my use case, but feel free declining it.
I'm a tmux user and I uses a key binding which depending on the current execution process does several things.

is_fzf='echo "#{pane_current_command}" | grep -iqE "(^|\/)fzf$"'

bind -n C-h run-shell "($is_vim && tmux send-keys C-h) || \
                 ($is_fzf && tmux send-keys C-h) || \
                 ($is_zsh_prompt && tmux send-keys C-h) || \
                 tmux select-pane -L"

Currently if fzf is the current execution process, the process name is bash. With these changes the process name is fzf and I'm able to capture it in tmux.

[junegunn]

Thanks, it makes sense but it seems like this will require an extra level of escaping of arguments. e.g. ls | fzf-tmux -q "foo'bar"

Is there a clear, simple solution to the issue? I'd like to avoid making it even more complicated than it currently is now.

[richiware]

I've made changes and now it supports an extra level of escaping of arguments. I've overwritten the previous commit with --amend.

[junegunn]

Please update line 181 as well, which is used when fzf is started without stdin pipe.

[junegunn]

How about using sh -c instead? Although /bin/sh is no different from /bin/bash on many systems, sometimes it's linked to a lighter posix-compliant shell such as dash.

[richiware]

I've updated the PR with your suggestions.

[junegunn]

Unfortunately, there are failing test cases. Haven't looked into it, it could be an issue of test cases. I'll look into it when I get some time.

[junegunn]

https://s3.amazonaws.com/archive.travis-ci.org/jobs/279390715/log.txt?X-Amz-Expires=30&X-Amz-Date=20170926T091527Z&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAJRYRXRSVGNKPKO5A/20170926/us-east-1/s3/aws4_request&X-Amz-SignedHeaders=host&X-Amz-Signature=d5b1c2d189b7eb6eb8e6cf9282ef022ecd4931032f69c5c520784b3e44a52623

[junegunn]

A couple things I found out:

1. exec in dash does not support -a argument, and that's why the tests are failing on Travis CI. So we should use bash instead of sh as in your original suggestion.
2. The patch does not work as expected when fzf-tmux is started without stdin pipe. tmux list-panes -F "#{window_index} #{pane_index} #{pane_current_command}" -a only shows bash. It looks like because of cd $(printf %q "$PWD"), tmux starts another layer of bash. Moving cd fixes the issue.

So it becomes:

diff --git a/bin/fzf-tmux b/bin/fzf-tmux
index d7ce7a6..79407e6 100755
--- a/bin/fzf-tmux
+++ b/bin/fzf-tmux
@@ -178,14 +178,14 @@ if [[ -n "$term" ]] || [[ -t 0 ]]; then
   cat <<< "\"$fzf\" $opts > $fifo2; echo \$? > $fifo3 $close" >> $argsf
   TMUX=$(echo $TMUX | cut -d , -f 1,2) tmux set-window-option synchronize-panes off \;\
     set-window-option remain-on-exit off \;\
-    split-window $opt "cd $(printf %q "$PWD");$envs bash $argsf" $swap \
+    split-window $opt "$envs bash -c 'cd $(printf %q "$PWD"); exec -a fzf bash $argsf'" $swap \
     > /dev/null 2>&1
 else
   mkfifo $fifo1
   cat <<< "\"$fzf\" $opts < $fifo1 > $fifo2; echo \$? > $fifo3 $close" >> $argsf
   TMUX=$(echo $TMUX | cut -d , -f 1,2) tmux set-window-option synchronize-panes off \;\
     set-window-option remain-on-exit off \;\
-    split-window $opt "$envs bash $argsf" $swap \
+    split-window $opt "$envs bash -c 'exec -a fzf bash $argsf'" $swap \
     > /dev/null 2>&1
   cat <&0 > $fifo1 &
 fi

[richiware]

Thanks a lot. I applied your changes and travis is working. Thanks for your time.

[junegunn]

Thanks, let's merge this and see if anyone complains :)