Skip to content

Convert ezbake to use junction-api types. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Convert ezbake to use junction-api types. #27

merged 2 commits into from
Oct 18, 2024

Conversation

blinsay
Copy link
Contributor

@blinsay blinsay commented Oct 17, 2024

Use junction-api types for xDS and kube conversions, which means that pushing dynamic config can now be done with junction-client dumping kube yaml.

This ezbake passes smoke tests, but definitely have problems with xDS resource names not being, since we don't take service ports into account. Since we're still passing smoke tests and this enables dynamic config, I'm going to push it.

After this comes a quick sequence of follow-up PRs to:

  • Add resource name mappings to junction-api and support for generating/parsing unique xdstp:// URLs for any Target.
  • Switch to using those names in ezbake, for both xDS on the wire and internal caching. No more collisions!
  • Switch junction-client to expecting and parsing xdstp:// URLs off the wire to figure out target data.

@blinsay
Copy link
Contributor Author

blinsay commented Oct 18, 2024

I bumped MSRV to 1.79 to match junction-client. We got a CI failure testing on 1.76 because junction-client takes advantage of some temporary lifetime extension stuff that got added in 1.79.

@blinsay blinsay merged commit c266316 into main Oct 18, 2024
4 checks passed
@blinsay blinsay deleted the benl/use-api branch October 18, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant